[PATCH] D79578: [mlir] NFC: Rename LoopOps dialect to SCF (Structured Control Flow)

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added a comment.

In D79578#2029705 <https://reviews.llvm.org/D79578#2029705>, @PeteSteinfeld wrote:

> @ftynse and @antiagainst , note that one of the clients of mlir is the flang project.  Since this revision changed the interface of mlir, all clients of mlir should be checked to see if they still build and test correctly before delivering such changes.  Note that the person who knows most about flang's dependency on mlir is @schweitz, but any member of the flang team should be able to verify if a change works for flang.


I'm sorry this broke your build, I had approved the fix that was mailed before this message.

I don't know who are the members of the flang team (is there a list?) and would feel concerned if we need to block any changes to MLIR APIs for review by people other than regular MLIR reviewers. If something is broken by an identifiable commit, and the fix isn't obvious, the usual policy in LLVM is to revert and report the problem to the author of the commit. Sometimes, it may be faster to just write the author a quick direct email. Generally, this is something that can and should be solved with a pre-merge check, but the one we have is broken for random reasons so often that it becomes useless.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79578/new/

https://reviews.llvm.org/D79578