[PATCH] D79683: [mlir] Add std.source and std.sink ops.
Alex Zinenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 11 06:24:21 PDT 2020
ftynse added a comment.
+1 to not putting these in the standard dialect. We didn't want a generic `cast` operation precisely because it could create values with unclear semantics. I would rather have it in a dedicated dialect rather than in the Test dialect. If you intend to build a bugpoint analog, you'd end up with a dependency of tools/bugpoint on test/lib, which sounds awkward.
================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:2167
+ // This op is fully verified by its declarative specification.
+ let verifier = ?;
+}
----------------
You can omit this line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79683/new/
https://reviews.llvm.org/D79683
More information about the llvm-commits
mailing list