[PATCH] D75670: [FPEnv] Intrinsic llvm.roundeven

Serge Pavlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 11 05:52:15 PDT 2020


sepavloff marked 3 inline comments as done.
sepavloff added inline comments.


================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:1416
   case Intrinsic::strip_invariant_group:
+  case Intrinsic::roundeven:
   case Intrinsic::masked_load:
----------------
craig.topper wrote:
> This should probably be with ceil/floor/trunc etc. further down?
Sure.


================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:1504
   case Intrinsic::experimental_constrained_round:
   case Intrinsic::experimental_constrained_trunc:
   case Intrinsic::experimental_constrained_nearbyint:
----------------
craig.topper wrote:
> should constrained_roundeven be here?
Indeed. Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75670/new/

https://reviews.llvm.org/D75670





More information about the llvm-commits mailing list