[PATCH] D78884: [CMake] -gen-dag-isel: add -omit-comments if neither Debug nor RelWithDebInfo

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/cmake/modules/TableGen.cmake:59
+  if (NOT (uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG" OR
+           uppercase_CMAKE_BUILD_TYPE STREQUAL "RELWITHDEBINFO"))
+    list(FIND ARGN "-gen-dag-isel" idx)
----------------
IMO this condition is a bit awkward, but I can't suggest a better one. I think to be thorough we might want to raise this up to a cmake option next to `LLVM_OPTIMIZED_TABLEGEN`, but I won't insist on it.

I use a release build, and I appreciate comments in other table generated files, but I have never debugged DAG isel matchers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78884/new/

https://reviews.llvm.org/D78884