[PATCH] D78884: [CMake] -gen-dag-isel: add -omit-comments if neither Debug nor RelWithDebInfo

Thu May 7 16:51:53 PDT 2020

MaskRay added a comment.

In D78884#2026270 <https://reviews.llvm.org/D78884#2026270>, @thakis wrote:

> Nice find! Should we just disable them always unless someone explicitly asks for them?
>
> Please wait with landing for nhaehnle to chime in.

Yeah, we can teach more TableGen backends to understand `-omit-comments`...

I guess comments are occasionally useful for some developers debugging code in generated code. If the build is a non-debug one, then certainly these comments are not needed...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78884/new/

https://reviews.llvm.org/D78884