[PATCH] D79643: [COFF] Migrate COFFObjectFile to Expected<T>

[Reid Kleckner via Phabricator via llvm-commits]

rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: llvm/tools/obj2yaml/coff2yaml.cpp:142
 
+  ExitOnError Err("Invalid section table");
   StringMap<bool> SymbolUnique;
----------------
MaskRay wrote:
> In the binary utilities (e.g. obj2yaml), we tend to not capitalize error messages. I think the error message may be temporary, because we should propagate the error to the caller, instead of calling `exit` directly when something goes wrong.
I'll lower case it. But, seeing as this is tool code, should we really propagate the error to the caller? Shouldn't the tool just exit here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79643/new/

https://reviews.llvm.org/D79643