[PATCH] D79643: [COFF] Migrate COFFObjectFile to Expected<T>

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/obj2yaml/coff2yaml.cpp:142
 
+  ExitOnError Err("Invalid section table");
   StringMap<bool> SymbolUnique;
----------------
In the binary utilities (e.g. obj2yaml), we tend to not capitalize error messages. I think the error message may be temporary, because we should propagate the error to the caller, instead of calling `exit` directly when something goes wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79643/new/

https://reviews.llvm.org/D79643