[PATCH] D79643: [COFF] Migrate COFFObjectFile to Expected<T>

[Reid Kleckner via Phabricator via llvm-commits]

rnk created this revision.
rnk added a reviewer: mstorsjo.
Herald added subscribers: rupprecht, MaskRay, hiraditya.
Herald added a reviewer: alexshap.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a reviewer: MaskRay.
Herald added a project: LLVM.

I noticed that std::error_code() does one-time initialization. Avoid
that overhead with Expected<T> and llvm::Error. Also, it is consistent
with the virtual interface and ELF, and generally cleaner.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79643

Files:
  lld/COFF/Chunks.cpp
  lld/COFF/InputFiles.cpp
  lld/COFF/Symbols.cpp
  llvm/include/llvm/Object/COFF.h
  llvm/lib/Object/COFFObjectFile.cpp
  llvm/tools/llvm-objcopy/COFF/Reader.cpp
  llvm/tools/llvm-objdump/COFFDump.cpp
  llvm/tools/llvm-readobj/COFFDumper.cpp
  llvm/tools/obj2yaml/coff2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79643.262925.patch
Type: text/x-patch
Size: 15809 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200508/b9b73444/attachment.bin>