[PATCH] D79252: [PowerPC][AIX] Spill CSRs to the ABI specified stack offsets.

Fri May 8 11:48:15 PDT 2020

ZarkoCA added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:230
+    // Add AIX's extra CSR.
+    {PPC::R13, -76},

----------------
Is the extra CSR only applicable to 32BIT AIX? Eg. is X13 not a CSR in 64BIT AIX? 

================
Comment at: llvm/test/CodeGen/PowerPC/aix-csr.ll:176-182
+declare double @dummy(i32 signext);
+
+define dso_local double @fprs_and_gprs(i32 signext %i) {
+  call void asm sideeffect "", "~{r13},~{r14},~{r25},~{r31},~{f14},~{f19},~{f21},~{f31}"()
+  %result = call double @dummy(i32 signext %i)
+  ret double %result
+}
----------------
What are the other tests in this file showing that this one doesn't?  It seems to me this test makes at least the `gprs_only` test redundant.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79252/new/

https://reviews.llvm.org/D79252