[PATCH] D79606: [ARM] Convert VDUPLANE to VDUP under MVE
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 7 16:19:53 PDT 2020
efriedma added a comment.
Some of the code differences here make me suspect we're missing combines for VDUPLANE. But that's not really something you need to concern yourself with here, I guess.
If you never want VDUPLANE, it doesn't seem like there's much point to generating it in the first place; I guess you want to continue supporting it just to make it easier to share code between NEON and MVE?
================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:13853
+ SDValue Extract;
+ if (ExtractVT == MVT::f16) {
+ // FP16 are always a little special and go via a VGETLANEu to stop it
----------------
I guess if you didn't have a special case for f16 here, you could still eventually get to the same place, but it would take some extra steps?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79606/new/
https://reviews.llvm.org/D79606
More information about the llvm-commits
mailing list