[PATCH] D79127: [XCOFF][AIX] Emit correct alignment for csect

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/lib/MC/MCContext.cpp:624
+  if (Type != XCOFF::XTY_ER)
+    Result->setAlignment(Align(4));
   Entry.second = Result;
----------------
DiggerLin wrote:
> how about to define static const expr DefaultAlign=4 ; in the MCSectionXCOFF  class ?
Thanks. Just realized I can do this in MCSectionXCOFF constructor as well.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1716
+bool PPCAIXAsmPrinter::doFinalization(Module &M) {
+  if (TM.getDataSections())
+    report_fatal_error("data sections are not yet supported");
----------------
daltenty wrote:
> I'm not clear why we need this check here? Trying to SelectionSectionForGlobal will already give us an error if either Function/Data sections are on. Is there a unique reason that this approach won't work with data-sections? If so, a comment is probably in order.
Thanks. Added reasoning in the comment. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79127/new/

https://reviews.llvm.org/D79127