[PATCH] D79127: [XCOFF][AIX] Emit correct alignment for csect
David Tenty via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 4 14:00:16 PDT 2020
daltenty added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1716
+bool PPCAIXAsmPrinter::doFinalization(Module &M) {
+ if (TM.getDataSections())
+ report_fatal_error("data sections are not yet supported");
----------------
I'm not clear why we need this check here? Trying to SelectionSectionForGlobal will already give us an error if either Function/Data sections are on. Is there a unique reason that this approach won't work with data-sections? If so, a comment is probably in order.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79127/new/
https://reviews.llvm.org/D79127
More information about the llvm-commits
mailing list