[PATCH] D79501: [DebugInfo] Fix handling DW_OP_call_ref in DWARF64 units.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin updated this revision to Diff 262616.
ikudrin marked an inline comment as done.
ikudrin added a comment.

- The DWARF format was made optional in `DWARFExpression`.
- Added a test to check that `DW_OP_call_ref` is not supported in location lists. That checks the code path when the DWARF format for `DWARFExpression` is not specified.

@aprantl, how do you find this variant?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79501/new/

https://reviews.llvm.org/D79501

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDie.cpp
  llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp
  llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
  llvm/test/DebugInfo/X86/DW_OP_call_ref_dwarf64.s
  llvm/test/DebugInfo/X86/DW_OP_call_ref_unexpected.s
  llvm/tools/llvm-dwarfdump/Statistics.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79501.262616.patch
Type: text/x-patch
Size: 13708 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200507/9949cc0c/attachment.bin>