[PATCH] D79501: [DebugInfo] Fix handling DW_OP_call_ref in DWARF64 units.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:135
+          // format, cannot be used in call frame instructions, see Section
+          // 6.4.2 in DWARFv5. Thus, just pass a dummy value as the format.
           Instructions.back().Expression =
----------------
This comment is correct now, but without verification, this is bound to break eventually. Would it be possible to just pass the correct value here, or, alternatively, make the format optional and pass an `llvm::None` value here and then produce an error in DWARFExpression if no format was specified when one is needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79501/new/

https://reviews.llvm.org/D79501