[PATCH] D79505: [mlir][StandardToLLVM] Add SinOp to LLVM dialect and lowering of std.sin to this op.

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 15:55:36 PDT 2020


nicolasvasilache added a comment.

How does this relate to how tanh evolved?
In the past there was an op for tanh but it was backpedaled on, I do not remember the rationale for removing it offhand but we def. want consistency between trig functions,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79505/new/

https://reviews.llvm.org/D79505





More information about the llvm-commits mailing list