[PATCH] D79506: Fix ShapeBase.td

[Sean Silva via Phabricator via llvm-commits]

silvas created this revision.
silvas added a reviewer: jpienaar.
Herald added subscribers: llvm-commits, Kayjukh, frgossen, grosul1, Joonsoo, stephenneuendorffer, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, rriddle.
Herald added 1 blocking reviewer(s): jpienaar.
Herald added a project: LLVM.
jpienaar accepted this revision.
jpienaar added a comment.
This revision is now accepted and ready to land.
silvas updated this revision to Diff 262421.
silvas marked an inline comment as done.

Looks good with the comment about file's purpose updated.


silvas added a comment.

Update



================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeBase.td:9
+//
+// This is the operation definition file for Shape dialect operations.
+//
----------------
This file seems to contain the dialect definition and types instead (e.g., there are no operations in here).


- Add license header.
- Remove TODO about extracting ShapeBase.td


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79506

Files:
  mlir/include/mlir/Dialect/Shape/IR/ShapeBase.td


Index: mlir/include/mlir/Dialect/Shape/IR/ShapeBase.td
===================================================================
--- mlir/include/mlir/Dialect/Shape/IR/ShapeBase.td
+++ mlir/include/mlir/Dialect/Shape/IR/ShapeBase.td
@@ -1,9 +1,20 @@
+//===- ShapeBase.td ----------------------------------------*- tablegen -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+//
+// Base definitions for the `shape` dialect.
+//
+//===----------------------------------------------------------------------===//
+
 #ifndef SHAPE_BASE_TD
 #define SHAPE_BASE_TD
 
 include "mlir/IR/OpBase.td"
 
-// TODO(jpienaar): Move to base.
 def AnyShaped: ShapedContainerType<[AnyType], IsShapedTypePred, "shaped">;
 
 //===----------------------------------------------------------------------===//


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79506.262421.patch
Type: text/x-patch
Size: 1031 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200506/7d69ffde/attachment-0001.bin>