[PATCH] D79484: [DebugInfo] Fortran module DebugInfo support in LLVM
Sourabh Singh Tomar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 6 11:20:00 PDT 2020
SouraVX added inline comments.
================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2139
StringRef getAPINotesFile() const { return getStringOperand(4); }
+ DIFile *getFile() const { return cast_or_null<DIFile>(getRawFile()); }
+ unsigned getLineNo() const { return LineNo; }
----------------
aprantl wrote:
> The parent class DIScope already provides a `getFile()` method. Are we storing the file operand twice?
Didn't get you completely here, I think that's needed, if you're asking.
Is there better way to accomplish this ? I remember noting some failures when using parent `DIScope` `getFile`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79484/new/
https://reviews.llvm.org/D79484
More information about the llvm-commits
mailing list