[PATCH] D79484: [DebugInfo] Fortran module DebugInfo support in LLVM

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added a comment.

Thanks for review @aprantl .

> Please make sure to provide a bitcode/assembler roundtrip test, maybe in test/Assembler/dimodule.ll

I worked on this too, Unfortunately due to messy workspace, I missed out to add this. Meanwhile I have this locally. I guess this test case addresses another concern of yours:

> Will this crash when we get an input with only 6 records?



> Is the line and file is necessary because in Fortran you may have more than one module declaration per file? Out of curiosity, what does the debugger use the line/file info for?

Yes this is necessary, GDB uses these line/file to display fortran modules info:

  (gdb) info modules
  File test.f90:
  18:     mod2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79484/new/

https://reviews.llvm.org/D79484