[PATCH] D78129: Add Marvell ThunderX3T110 support

Wed May 6 08:02:54 PDT 2020

joelkevinjones added a comment.

> It is okay'ish to set `CompleteModel = 0` if you're not interested in describing all instructions. The other way is of course to add the missing instruction to the model.

We are trying to describe all instructions. The issue Wei is having is that the pointer auth instructions are being called out in the error message, but their timing information is defined—see the very end of AArch64SchedThunderX3T110.td for AUTDZA.

> But first things first. @chill commented earlier about predicates. I also don't think you need to add `HasV8_3a` for the reason Momchill described, and there is still one left AArch64InstrInfo.td.
> 
> And while I am still looking into this, let me ask the question what I am wondering: why do you need to change the other scheduling models? These instructions are always supported, as a NOP, or otherwise.

The changes to UnsupportedFeatures that was in every model has been taken out. I'm not sure why UnsupportedFeatures exists at all, but it isn't just AArch64 that has this.

Should the latest version be put up even if it fails on table-gen?  That would make things easier to review.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78129/new/

https://reviews.llvm.org/D78129