[PATCH] D78764: [RISCV] Update debug scratch register names

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 08:03:34 PDT 2020


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

LGTM, thanks. Left one tiny nit inline.



================
Comment at: llvm/lib/Target/RISCV/Utils/RISCVBaseInfo.h:160
   unsigned Encoding;
+  // FIXME: support multiple aliases when needed
+  const char *AltName;
----------------
I'd drop this FIXME - it's not an immediate problem and the limitation is documented in RISCVSystemOperands.td


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78764/new/

https://reviews.llvm.org/D78764





More information about the llvm-commits mailing list