[PATCH] D78186: [flang] Don't check __cplusplus value with MSVC.

مهدي شينون (Mehdi Chinoune) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 04:48:38 PDT 2020


ChinouneMehdi added a comment.

In D78186#2019986 <https://reviews.llvm.org/D78186#2019986>, @aaron.ballman wrote:

> I don't think this preserves the intended behavior of the original code -- now MSVC will never check for C++17 mode. I believe the correct way to fix this is to set `/Zc:__cplusplus` when compiling with MSVC, unless there's a reason that's not possible?


Well, C++17 mode is already checked with CMake, so there is no need to check it with the compiler. I excluded MSVC just because @sscalpone insisted to preserve the original code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78186/new/

https://reviews.llvm.org/D78186





More information about the llvm-commits mailing list