[PATCH] D78186: [flang] Don't check __cplusplus value with MSVC.

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 04:48:37 PDT 2020


aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.

I don't think this preserves the intended behavior of the original code -- now MSVC will never check for C++17 mode. I believe the correct way to fix this is to set `/Zc:__cplusplus` when compiling with MSVC, unless there's a reason that's not possible?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78186/new/

https://reviews.llvm.org/D78186





More information about the llvm-commits mailing list