[PATCH] D79306: llvm rejects DWARF operator DW_OP_push_object_address.

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 5 02:06:40 PDT 2020


djtodoro added inline comments.


================
Comment at: llvm/test/DebugInfo/dwarfdump-pushobjectaddress.ll:1
+; This test checks whether DWARF operator DW_OP_push_object_address
+; is accepted and processed.
----------------
alok wrote:
> alok wrote:
> > djtodoro wrote:
> > > The recommendation is (I've learned this recently) using double `;` for high-level comments.
> > Thanks for your comment.  sorry I did not understand it clearly. Do you mean double semi colon ";;" in place of ";"?
> Thanks for your comment, I shall update my patch.
Yes. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79306/new/

https://reviews.llvm.org/D79306





More information about the llvm-commits mailing list