[PATCH] D79306: llvm rejects DWARF operator DW_OP_push_object_address.

[Alok Kumar Sharma via Phabricator via llvm-commits]

alok marked 6 inline comments as done.
alok added inline comments.


================
Comment at: llvm/test/DebugInfo/dwarfdump-pushobjectaddress.ll:1
+; This test checks whether DWARF operator DW_OP_push_object_address
+; is accepted and processed.
----------------
alok wrote:
> djtodoro wrote:
> > The recommendation is (I've learned this recently) using double `;` for high-level comments.
> Thanks for your comment.  sorry I did not understand it clearly. Do you mean double semi colon ";;" in place of ";"?
Thanks for your comment, I shall update my patch.


================
Comment at: llvm/test/DebugInfo/dwarfdump-pushobjectaddress.ll:7
+
+; Test whether DW_OP_push_object_address is accepted.
+
----------------
djtodoro wrote:
> Likewise.
Thanks for your comment, I shall update my patch.


================
Comment at: llvm/test/DebugInfo/dwarfdump-pushobjectaddress.ll:13
+
+; Below is the original test case this IR is generated from
+;---------------------------
----------------
djtodoro wrote:
> Likewise.
Thanks for your comment, I shall update my patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79306/new/

https://reviews.llvm.org/D79306