[PATCH] D79309: [llvm-objdump] -d: delete spaces among raw instruction bytes

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Hmm... I'm not convinced that this is the right thing to do. Believe it or not, there will be people out there with scripts who parse the instruction bytes in their scripts for whatever reason. I can think of some reasons where this might be slightly useful. Changing this behaviour will break things for them. I also feel like it's less readable to me, as it takes more effort to identify the individual bytes, but I acknowledge that's a personal opinion.

You said the motivation is because you want more columns to do another feature. If people want to use that feature and need narrower output, why can't they choose to opt-in (which they'd be doing for the new option) by disabling the raw instruction bytes?

Also, what about another option to control the spacing? Something like --compact, or maybe even something crazy that allows you to format individual bytes using something like a printf format specifier. A good example of this is the od tool which provides different options for width per byte.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79309/new/

https://reviews.llvm.org/D79309