[PATCH] D79309: [llvm-objdump] -d: delete spaces among raw instruction bytes

Michael Trent via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 10:09:33 PDT 2020


mtrent added inline comments.


================
Comment at: llvm/lib/MC/MCInstPrinter.cpp:37
 
+void llvm::dumpBytesNoSpace(ArrayRef<uint8_t> bytes, raw_ostream &OS) {
+  static const char hex_rep[] = "0123456789abcdef";
----------------
Isn't this just llvm::dumpBytes with an optional 3rd parameter to suppress the First if/else test? I guess it's only a small amount of copy-pasted code...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79309/new/

https://reviews.llvm.org/D79309





More information about the llvm-commits mailing list