[PATCH] D79288: [AMDGPU][MC] Enabled 21-bit signed offsets for SMEM instructions

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 4 11:48:59 PDT 2020


dp marked an inline comment as done.
dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:1313-1315
   if (!IsBuffer && hasSMRDSignedImmOffset(ST)) {
     assert(hasSMEMByteOffset(ST));
     return isInt<20>(ByteOffset) ? Optional<int64_t>(ByteOffset) : None;
----------------
This code should probably be corrected as well but I do not know if codegen is ready for this change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79288/new/

https://reviews.llvm.org/D79288





More information about the llvm-commits mailing list