[PATCH] D79333: Response to review comments

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld created this revision.
Herald added a reviewer: DavidTruby.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Removed an unnecessary "const" as per Tim's recommendation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79333

Files:
  flang/include/flang/Evaluate/check-expression.h
  flang/lib/Evaluate/check-expression.cpp


Index: flang/lib/Evaluate/check-expression.cpp
===================================================================
--- flang/lib/Evaluate/check-expression.cpp
+++ flang/lib/Evaluate/check-expression.cpp
@@ -320,7 +320,7 @@
 template <typename A>
 void CheckSpecificationExpr(const A &x, parser::ContextualMessages &messages,
     const semantics::Scope &scope, const IntrinsicProcTable &table,
-    const SpecificationExprContext specExprContext) {
+    SpecificationExprContext specExprContext) {
   if (auto why{
           CheckSpecificationExprHelper{scope, table, specExprContext}(x)}) {
     messages.Say("Invalid specification expression: %s"_err_en_US, *why);
Index: flang/include/flang/Evaluate/check-expression.h
===================================================================
--- flang/include/flang/Evaluate/check-expression.h
+++ flang/include/flang/Evaluate/check-expression.h
@@ -52,7 +52,7 @@
 template <typename A>
 void CheckSpecificationExpr(const A &, parser::ContextualMessages &,
     const semantics::Scope &, const IntrinsicProcTable &,
-    const SpecificationExprContext);
+    SpecificationExprContext);
 extern template void CheckSpecificationExpr(const Expr<SomeType> &x,
     parser::ContextualMessages &, const semantics::Scope &,
     const IntrinsicProcTable &, const SpecificationExprContext);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79333.261830.patch
Type: text/x-patch
Size: 1332 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200504/fd4cb313/attachment.bin>