[PATCH] D79309: [llvm-objdump] -d: delete spaces among raw instruction bytes
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun May 3 16:27:35 PDT 2020
MaskRay added a comment.
In D79309#2016929 <https://reviews.llvm.org/D79309#2016929>, @joerg wrote:
> The more compact output is a lot harder to read when you have to find embedded data. I wouldn't mind dropping half the spaces to have columns of 4 hex digits, but anything more is really hard to read.
Embedded data is like the following:
// llvm/test/tools/llvm-objdump/ELF/ARM/disassemble-code-data-mix.s (also see D79284)
// ARM .byte/.short/.word
00000020 <$d.1>:
20: 00 00 00 00 .word 0x00000000
// STT_OBJECT/STT_COMMON symbols
00000024 <myStr>:
24: 74 65 73 74 20 73 74 72 test str
2c: 69 6e 67 00 ing.
If we extend this patch to affect non-x86 *instructions* as well:
18: 04b09de4 ldr r11, [sp], #4
1c: 1eff2fe1 <unknown>
## For consistency, we should delete spaces here as well.
00000020 <$d.1>:
20: 00 00 00 00 .word 0x00000000
## dumpELFData, unaffected.
00000024 <myStr>:
24: 74 65 73 74 20 73 74 72 test str
2c: 69 6e 67 00 ing.
Note that `dumpELFData` is not affected.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79309/new/
https://reviews.llvm.org/D79309
More information about the llvm-commits
mailing list