[PATCH] D79309: [llvm-objdump] -d: delete spaces among raw instruction bytes

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 3 15:55:52 PDT 2020


MaskRay added a comment.

In D79309#2016924 <https://reviews.llvm.org/D79309#2016924>, @joerg wrote:

> I'm not sure about this change. It might make sense on x86, but many RISC architectures love to put data into the instruction stream and being able to pick them out is quite important for understanding the disassembly.


I don't understand your comment. This patch delete spaces to make the output compacter, how does that make RISC architectures unhappy?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79309/new/

https://reviews.llvm.org/D79309





More information about the llvm-commits mailing list