[PATCH] D79215: [llvm][NFC] Inliner: simplify inlining decision logic

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Sat May 2 23:04:25 PDT 2020


sounds good to me.

On Sat, May 2, 2020 at 9:43 PM David Blaikie via Phabricator <
reviews at reviews.llvm.org> wrote:

> dblaikie added a comment.
>
> In D79215#2016602 <https://reviews.llvm.org/D79215#2016602>, @mtrofin
> wrote:
>
> > In D79215#2016597 <https://reviews.llvm.org/D79215#2016597>, @davidxl
> wrote:
> >
> > > yes, that captured what I meant.
> >
> >
> > So I have a conclusion, do I:
> >
> > - do nothing, or
> > - create a new patch as per the first version of this patch here (or
> revert and do that?)
> >
> >   Thanks!
>
>
> If it's OK with you - could you commit the Optional version (like the
> first version of your patch)? no need to send it for review, you can commit
> it directly. But if you can follow-up here to mention the commit hash when
> it's done, that'd be great!
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D79215/new/
>
> https://reviews.llvm.org/D79215
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200502/731fb9e7/attachment.html>


More information about the llvm-commits mailing list