<div dir="ltr"><div class="gmail_default" style="font-family:monospace;font-size:small;color:#000000">sounds good to me.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, May 2, 2020 at 9:43 PM David Blaikie via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">dblaikie added a comment.<br>
<br>
In D79215#2016602 <<a href="https://reviews.llvm.org/D79215#2016602" rel="noreferrer" target="_blank">https://reviews.llvm.org/D79215#2016602</a>>, @mtrofin wrote:<br>
<br>
> In D79215#2016597 <<a href="https://reviews.llvm.org/D79215#2016597" rel="noreferrer" target="_blank">https://reviews.llvm.org/D79215#2016597</a>>, @davidxl wrote:<br>
><br>
> > yes, that captured what I meant.<br>
><br>
><br>
> So I have a conclusion, do I:<br>
><br>
> - do nothing, or<br>
> - create a new patch as per the first version of this patch here (or revert and do that?)<br>
><br>
>   Thanks!<br>
<br>
<br>
If it's OK with you - could you commit the Optional version (like the first version of your patch)? no need to send it for review, you can commit it directly. But if you can follow-up here to mention the commit hash when it's done, that'd be great!<br>
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D79215/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D79215/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D79215" rel="noreferrer" target="_blank">https://reviews.llvm.org/D79215</a><br>
<br>
<br>
<br>
</blockquote></div>