[PATCH] D78434: [mlir] resolve types from attributes in assemblyFormat

[Martin Waitz via Phabricator via llvm-commits]

tali marked 5 inline comments as done.
tali added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/OpFormatGen.cpp:735
       continue;
     // Ensure that we don't verify the same variables twice.
     const NamedTypeConstraint *variable = resolver.getVariable();
----------------
rriddle wrote:
> rriddle wrote:
> > We will also need to add verification of the attribute here if the transformer is non-trivial.
> Although I suspect 99% of the cases are already handled because we check the storage type when parsing, happy to leave this as a followup for now.
Which checks would you find useful here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78434/new/

https://reviews.llvm.org/D78434