[PATCH] D78434: [mlir] resolve types from attributes in assemblyFormat
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 28 11:17:28 PDT 2020
rriddle accepted this revision.
rriddle added a comment.
This revision is now accepted and ready to land.
LGTM after adding handling for AllTypesMatch and a test for it.
================
Comment at: mlir/test/lib/Dialect/Test/TestOps.td:1250
+def FormatTypesMatchVarOp : TEST_Op<"format_types_match_var", [
+ TypesMatchWith<"result type matches operand", "value", "result", "$_self">
+ ]> {
----------------
rriddle wrote:
> Can you add an example for AllTypesMatch?
With attributes I mean.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78434/new/
https://reviews.llvm.org/D78434
More information about the llvm-commits
mailing list