[PATCH] D79220: [XCOFF] XCOFF constants, MCObjectFileInfo placeholder code for DWARF; NFC

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:96
+  SSUBTYP_DWFRAME = 0xA'0000, ///< DWARF frame section
+  SSUBTYP_DWMAC = 0xB'0000    ///< DWARF macinfo section
+};
----------------
jasonliu wrote:
> nit:
> If we want to have the comments telling what each one is doing, do we want to consider taking the description from https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/filesreference/XCOFF.html
> I find the description there is much clear than the short names we are using in the comments.
> ```
>      Value   |     Macro	      | Description
> 		-----------------------------------------------
> 		0x10000  | SSUBTYP_DWINFO   | DWARF info section
> 		0x20000  | SSUBTYP_DWLINE   | DWARF line-number section
> 		0x30000  | SSUBTYP_DWPBNMS  | DWARF public names section
> 		0x40000  | SSUBTYP_DWPBTYP  | DWARF public types section
> 		0x50000  | SSUBTYP_DWARNGE  | DWARF aranges section
> 		0x60000  | SSUBTYP_DWABREV  | DWARF abbreviation section
> 		0x70000  | SSUBTYP_DWSTR    | DWARF strings section
> 		0x80000  | SSUBTYP_DWRNGES  | DWARF ranges section
>     0x90000  | SSUBTYPE_DWLOC   | DWARF location lists section
> 		0xA0000  | SSUBTYPE_DWFRAME | DWARF frames section
> 	  0xB0000  | SSUBTYPE_DWMAC   | DWARF macros section
> ```
The "short names" here are precisely the second-half of the officially defined names. The descriptions from the AIX docs are a bad idea because they are ambiguous given DWARF 5's replacement of some of these with newer sections used for similar information and matching the same description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79220/new/

https://reviews.llvm.org/D79220