[PATCH] D79220: [XCOFF] XCOFF constants, MCObjectFileInfo placeholder code for DWARF; NFC
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 1 17:13:37 PDT 2020
jasonliu added inline comments.
================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:96
+ SSUBTYP_DWFRAME = 0xA'0000, ///< DWARF frame section
+ SSUBTYP_DWMAC = 0xB'0000 ///< DWARF macinfo section
+};
----------------
nit:
If we want to have the comments telling what each one is doing, do we want to consider taking the description from https://www.ibm.com/support/knowledgecenter/en/ssw_aix_72/filesreference/XCOFF.html
I find the description there is much clear than the short names we are using in the comments.
```
Value | Macro | Description
-----------------------------------------------
0x10000 | SSUBTYP_DWINFO | DWARF info section
0x20000 | SSUBTYP_DWLINE | DWARF line-number section
0x30000 | SSUBTYP_DWPBNMS | DWARF public names section
0x40000 | SSUBTYP_DWPBTYP | DWARF public types section
0x50000 | SSUBTYP_DWARNGE | DWARF aranges section
0x60000 | SSUBTYP_DWABREV | DWARF abbreviation section
0x70000 | SSUBTYP_DWSTR | DWARF strings section
0x80000 | SSUBTYP_DWRNGES | DWARF ranges section
0x90000 | SSUBTYPE_DWLOC | DWARF location lists section
0xA0000 | SSUBTYPE_DWFRAME | DWARF frames section
0xB0000 | SSUBTYPE_DWMAC | DWARF macros section
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79220/new/
https://reviews.llvm.org/D79220
More information about the llvm-commits
mailing list