[PATCH] D78709: [llvm-readobj] - Simplify conditions used for printing segment mappings. NFCI.

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4085
+  // Is section within the phdr both based on offset and VMA?
+  bool CheckOffset = (Sec.sh_type == ELF::SHT_NOBITS) &&
+                     (Sec.sh_offset > Phdr.p_offset &&
----------------
jhenderson wrote:
> grimar wrote:
> > jhenderson wrote:
> > > Shouldn't this be an `||` to match the old behaviour?
> > Right.
> I'm nervous that (presumably) no test failed because of this mistake, but I guess that the situation isn't any worse than before.
Me too. And this is what I've mentioned in the description: "Probably it can be
simplified and improved more, but we need to land test cases documenting/testing
all the current functionality first."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78709/new/

https://reviews.llvm.org/D78709