[PATCH] D78709: [llvm-readobj] - Simplify conditions used for printing segment mappings. NFCI.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4085
+  // Is section within the phdr both based on offset and VMA?
+  bool CheckOffset = (Sec.sh_type == ELF::SHT_NOBITS) &&
+                     (Sec.sh_offset > Phdr.p_offset &&
----------------
grimar wrote:
> jhenderson wrote:
> > Shouldn't this be an `||` to match the old behaviour?
> Right.
I'm nervous that (presumably) no test failed because of this mistake, but I guess that the situation isn't any worse than before.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78709/new/

https://reviews.llvm.org/D78709