[PATCH] D79214: [ADT] Fix SmallVector unused template instantiation on 32-bit systems.

[Andrew via Phabricator via llvm-commits]

browneee marked 3 inline comments as done.
browneee added inline comments.


================
Comment at: llvm/lib/Support/SmallVector.cpp:86
+// warnings when sizeof(Size_T) > sizeof(size_t).
+#if SIZE_MAX > UINT32_MAX
 template class llvm::SmallVectorBase<uint64_t>;
----------------
dblaikie wrote:
> smeenai wrote:
> > Wouldn't hurt to include `stdint.h` explicitly in this file, to ensure these constants are available.
> Sorry I didn't catch this - @browneee Could you commit this in a follow-up  (no need to send it for review)?
Done:
https://github.com/llvm/llvm-project/commit/a1bd5cd539f9e2fd34e522b848e751342985e882

Sorry I missed your comment smeenai. I didn't realize how phabricator shows approved with still open comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79214/new/

https://reviews.llvm.org/D79214