[PATCH] D79214: [ADT] Fix SmallVector unused template instantiation on 32-bit systems.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 17:11:14 PDT 2020


dblaikie added inline comments.


================
Comment at: llvm/lib/Support/SmallVector.cpp:86
+// warnings when sizeof(Size_T) > sizeof(size_t).
+#if SIZE_MAX > UINT32_MAX
 template class llvm::SmallVectorBase<uint64_t>;
----------------
smeenai wrote:
> Wouldn't hurt to include `stdint.h` explicitly in this file, to ensure these constants are available.
Sorry I didn't catch this - @browneee Could you commit this in a follow-up  (no need to send it for review)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79214/new/

https://reviews.llvm.org/D79214





More information about the llvm-commits mailing list