[PATCH] D79215: [llvm][NFC] Inliner: simplify inlining decision logic
    Mircea Trofin via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Apr 30 17:38:45 PDT 2020
    
    
  
mtrofin marked an inline comment as done.
mtrofin added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:457
+    setInlineRemark(CB, inlineCostStr(IC));
+    return None;
   }
----------------
davidxl wrote:
> Returning None simplifies the check of the return value a little, but it drops information. Perhaps just return IC in case the user needs to check it in different context?
That's the thing, the user doesn't use the IC in the 'don't inline' case.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79215/new/
https://reviews.llvm.org/D79215
    
    
More information about the llvm-commits
mailing list