[PATCH] D79215: [llvm][NFC] Inliner: simplify inlining decision logic

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 17:11:15 PDT 2020


davidxl added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:457
+    setInlineRemark(CB, inlineCostStr(IC));
+    return None;
   }
----------------
Returning None simplifies the check of the return value a little, but it drops information. Perhaps just return IC in case the user needs to check it in different context?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79215/new/

https://reviews.llvm.org/D79215





More information about the llvm-commits mailing list