[PATCH] D76863: Fix SelectionDAG Graph Printing on Windows

[Justice Adams via Phabricator via llvm-commits]

justice_adams added inline comments.


================
Comment at: llvm/lib/Support/GraphWriter.cpp:101
+  std::string N = Name.str();
+  N = N.substr(0, std::min<std::size_t>(N.size(), 140));
+
----------------
amccarth wrote:
> If `sys::fs::createTemporaryFile` can return a too-long path here, then it could do so for anyone else, too.  Should the length limit be handled there?
> 
> Is 140 arbitrary, a guestimate, or based on some actual limit?
@amccarth It appears to be arbitrary https://reviews.llvm.org/D3883

I'm open to moving the length limiting to 
```
sys::fs::createTemporaryFile
```
If that's preferred


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76863/new/

https://reviews.llvm.org/D76863