[PATCH] D76863: Fix SelectionDAG Graph Printing on Windows

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

Apologies for the drive-by questions.



================
Comment at: llvm/lib/Support/GraphWriter.cpp:101
+  std::string N = Name.str();
+  N = N.substr(0, std::min<std::size_t>(N.size(), 140));
+
----------------
If `sys::fs::createTemporaryFile` can return a too-long path here, then it could do so for anyone else, too.  Should the length limit be handled there?

Is 140 arbitrary, a guestimate, or based on some actual limit?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76863/new/

https://reviews.llvm.org/D76863