[PATCH] D79089: [flang] Add the proposal document and rationale for the internal naming module that was previously added.

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 10:08:28 PDT 2020


kiranchandramohan accepted this revision.
kiranchandramohan added a comment.



> The uniquing is required in the context of the MLIR Module symbol space. (Artifacts with a process lifetime such as functions, globals, etc.) Locals need not be uniqued as they have a unique identity as ssa-> values. (Their names are tracked with name attributes attached to the Op.)

Thanks @schweitz. Adding the above information to the doc might be helpful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79089/new/

https://reviews.llvm.org/D79089





More information about the llvm-commits mailing list