[PATCH] D79089: [flang] Add the proposal document and rationale for the internal naming module that was previously added.

[Eric Schweitz via Phabricator via llvm-commits]

schweitz added a comment.

In D79089#2012963 <https://reviews.llvm.org/D79089#2012963>, @kiranchandramohan wrote:

> Thanks @schweitz for the detailed reply.
>
> I have a couple more questions.
>  -> Isn't this necessary for the Block construct?
>  -> Will uniquing all names lead to lower readability of the IR? (Assuming that is what being proposed here) 
>  -> Yeah, renaming local variables back to original names (during lowering to LLVM IR) when there is no clash seems better for readability.


The uniquing is required in the context of the MLIR Module symbol space. (Artifacts with a process lifetime such as functions, globals, etc.) Locals need not be uniqued as they have a unique identity as ssa-values. (Their names are tracked with name attributes attached to the Op.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79089/new/

https://reviews.llvm.org/D79089