[PATCH] D79103: Fix ELF/linkerscript/input-archive.s w/ @ in path

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre marked an inline comment as done.
thopre added inline comments.


================
Comment at: lld/test/ELF/linkerscript/thunk-gen-mips.s:18-20
 # CHECK-ANY: 00000000         .text           00000000 _start
 # CHECK-ANY: 0010000c l     F .text           00000010 __LA25Thunk_too_far
 # CHECK-ANY: 00100020 g     F .text           00000024 too_far
----------------
thopre wrote:
> CHECK-ANY is not a valid FileCheck directive and the FileCheck invocation uses the default prefix. This test is only testing the presence of SYMBOL TABLE in the output of llvm-objdump -t :-)
The test seems to have bitrotted as a result. This is the output of objdump -t I get when I run it manually:

SYMBOL TABLE:
00000001 l       *ABS*  00000000 MAIN
00000001 l       *ABS*  00000000 TARGET
00108050 l       .got   00000000 .hidden _gp
0010003c l     F .text  00000010 __LA25Thunk_too_far
00000030 g       .text  00000000 _start
00100050 g     F .text  0000000c too_far

So wrong address and flag for _start, wrong address and size for too_far.

I presume CHECK-ANY was meant to be CHECK-DAG and thus the order does not matter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79103/new/

https://reviews.llvm.org/D79103