[PATCH] D79103: Fix ELF/linkerscript/input-archive.s w/ @ in path

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 09:02:47 PDT 2020


thopre marked an inline comment as done.
thopre added a comment.

In D79103#2012071 <https://reviews.llvm.org/D79103#2012071>, @jhenderson wrote:

> In D79103#2010743 <https://reviews.llvm.org/D79103#2010743>, @MaskRay wrote:
>
> > You did not fix `lld/test/ELF/linkerscript/thunk-gen-mips.s` initially. This made me wonder how you found the issue of `lld/test/ELF/linkerscript/input-archive.s`.
> >
> > Have you invoked `ninja check-lld` to ensure every test is good now?
>
>
> Wild guess: @thopre doesn't have all targets enabled?


Indeed, but that wouldn't have caught it anyway. See comment I've added on thunk-gen-mips.s



================
Comment at: lld/test/ELF/linkerscript/thunk-gen-mips.s:18-20
 # CHECK-ANY: 00000000         .text           00000000 _start
 # CHECK-ANY: 0010000c l     F .text           00000010 __LA25Thunk_too_far
 # CHECK-ANY: 00100020 g     F .text           00000024 too_far
----------------
CHECK-ANY is not a valid FileCheck directive and the FileCheck invocation uses the default prefix. This test is only testing the presence of SYMBOL TABLE in the output of llvm-objdump -t :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79103/new/

https://reviews.llvm.org/D79103





More information about the llvm-commits mailing list