[PATCH] D79165: [DebugInfo] - DWARFDebugFrame: do not call abort() on errors.

[George Rimar via Phabricator via llvm-commits]

grimar marked 2 inline comments as done.
grimar added a comment.

In D79165#2012656 <https://reviews.llvm.org/D79165#2012656>, @ikudrin wrote:

> You may want to add a note to PR45105 <https://bugs.llvm.org/show_bug.cgi?id=45105>.


Ah. I didn't see it, thanks! I faced this crash independently using another broken object.



================
Comment at: llvm/test/DebugInfo/X86/eh-frame-cie-id.s:1
-# RUN: llvm-mc -triple x86_64-unknown-linux %s -filetype=obj -o - | \
-# RUN:   not --crash llvm-dwarfdump -debug-frame - 2>&1 | \
-# RUN:   FileCheck %s
+# RUN: llvm-mc -triple x86_64-unknown-linux %s -filetype=obj -o %t
+# RUN: not llvm-dwarfdump -debug-frame %t 2>&1 | FileCheck %s
----------------
ikudrin wrote:
> Why do you need to keep that temporary file?
Having temporarily files helps to debug tests when they fail.


================
Comment at: llvm/test/DebugInfo/X86/eh-frame-cie-id.s:4
 
-# CHECK: Parsing FDE data at 0 failed due to missing CIE
+# CHECK: Parsing FDE data at 0x0 failed due to missing CIE
 
----------------
ikudrin wrote:
> Prefixing offsets with `0x` should be probably extracted to a separate patch.
This error message is just broken without `0x` as it prints values in hex, but you can't know it.
We often adjust/improve messages when doing similar changes. E.g. add error locations or an additional context.
This is the only LLVM test which is affected anyways.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79165/new/

https://reviews.llvm.org/D79165