[PATCH] D79165: [DebugInfo] - DWARFDebugFrame: do not call abort() on errors.

Thu Apr 30 06:46:47 PDT 2020

ikudrin added a comment.

Overall looks good. You may want to add a note to PR45105 <https://bugs.llvm.org/show_bug.cgi?id=45105>.

================
Comment at: llvm/test/DebugInfo/X86/eh-frame-cie-id.s:1
-# RUN: llvm-mc -triple x86_64-unknown-linux %s -filetype=obj -o - | \
-# RUN:   not --crash llvm-dwarfdump -debug-frame - 2>&1 | \
-# RUN:   FileCheck %s
+# RUN: llvm-mc -triple x86_64-unknown-linux %s -filetype=obj -o %t
+# RUN: not llvm-dwarfdump -debug-frame %t 2>&1 | FileCheck %s
----------------
Why do you need to keep that temporary file?

================
Comment at: llvm/test/DebugInfo/X86/eh-frame-cie-id.s:4

-# CHECK: Parsing FDE data at 0 failed due to missing CIE
+# CHECK: Parsing FDE data at 0x0 failed due to missing CIE

----------------
Prefixing offsets with `0x` should be probably extracted to a separate patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79165/new/

https://reviews.llvm.org/D79165